Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove copy code of FindTopRunner #585

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Remove copy code of FindTopRunner #585

merged 1 commit into from
Oct 20, 2023

Conversation

masa213f
Copy link
Contributor

@masa213f masa213f commented Oct 19, 2023

This PR removes the copy code of FindTopRunner.

Currently, FindTopRunner is defined twice, for mock and for actual mysql.
And the following PR made a difference.
#474

Signed-off-by: Masayuki Ishii [email protected]

@masa213f masa213f self-assigned this Oct 19, 2023
@masa213f masa213f marked this pull request as draft October 19, 2023 08:20
@masa213f masa213f marked this pull request as ready for review October 20, 2023 02:29
Copy link
Member

@ymmt2005 ymmt2005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ymmt2005 ymmt2005 merged commit a977d93 into main Oct 20, 2023
14 checks passed
@ymmt2005 ymmt2005 deleted the fix-findtoprunner branch October 20, 2023 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants